Check if unique flag raise validation error if non unique data #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bctiemann
approved these changes
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raises a validation error if trying to set unique on a field and non-unique data exists. The other way to do this is to query all the data in the table and annotate with a count of occurrences but that could be fairly DB heavy, this way just tries to create the index we will be creating later in save.
The code to do that is a bit different as you need to throw a unique error so that it will roll-back the transaction as you don't want to actually do the alter here, so the first try-catch is to catch the unique case to roll back the transaction and swallow the error, the try-catch on the IntegrityError is the one that raises the actual ValidationError.