Branch fails to sync if one of the changes has an object created with a tag assigned

[cah-william-parsley]

Plugin Version

0.5.2

NetBox Version

4.1.7

Python Version

3.10.14

Steps to Reproduce

1. Create a new branch, but don't activate it.
2. Create a device or circuit (or probably any object) in the main branch and assign a tag during creation.
3. Switch to the branch created in step 1 and try to sync it with main

Expected Behavior

Branch syncs with main without error.

Observed Behavior

There is a deserialization error during the sync. Error below. This might be related, or the same issue as #193

DeserializationError("['“tag-name” value must be an integer.']: (circuits.circuit:pk=2) field_value was 'tag-name'")

[cruse1977]

Confirmed this issue - this doesn't occur on sites (so any object is incorrect) but does on devices

DeserializationError("['“test2” value must be an integer.']: (dcim.device:pk=1) field_value was 'test2'")

[cruse1977]

This only occurs creating a device with a tag, adding a tag to an existing device syncs fine. Data in the changelog for the create tags "tags": ["Branch"]

[xocoru]

I faced the same issue

[jeremystretch]

Although this presents differently, I suspect it's caused by the same underlying problem as #193 (as mentioned). I'm going to mark this as blocked for now as investigation on that bug continues.

This is a different issue.

[jeremystretch]

Confirmed this issue - this doesn't occur on sites (so any object is incorrect) but does on devices

I was able to reproduce this on a site. The issue stems from tags being serialized with their name rather than their numeric IDs.

[jeremystretch]

This is due to a bug in NetBox's deserialize_object() utility function, which does not account for tags specified by name in the serialized data. I've opened netbox-community/netbox#18884 to address this in NetBox. Marking this as blocked for now.