-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Multiselect #9309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiselect #9309
Conversation
|
So does this new feature support my feature suggestion? Or is something else meant here? |
|
@LHBL2003 - This is not related to your issue no. |
|
Hopefully this will help clarify the intent of #8704 as I understand it. multiselect.mov |
|
Tried it out, works great! Found a very minor issue:
Everything from the bottom of the table and to where you clicked will be marked. The reason is that when using the Quick Search the table is replaced by HTMX. As such the state of the previous element will be wrong (doesn't exist anymore) and it will mark everything as it never finds the target element. Maybe you can clear the state whenever a HTMX table has been rendered. |
Ah! Great catch and great solution! Will implement shortly. Thanks for the feedback! :) |
|
@CroogQT - Expect getting some time to work on this? I think it's a great usability improvement. If you don't have the time I can give it a shot fixing the last small bug. |
|
Honestly I'm ok with merging this as-is, even with the bug. Happy to open a separate bug report to track the remaining work. |
|
More than fine by me. |
Fixes: #8704
Allows a user to shift click a checkbox to set the "checked" value of all check boxes between their selection and their previous selection to the new value of their selected checkbox.