Limit amount of nonracked devices displayed #9067
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 7, 2022 08:21
Fixes netbox-community#8920 Limits the amount of non-racked devices on Site and Location view to 10 and provides a link to the device list this is pre-filtered to the relevant site or location.
Fixing issue where Displaying 10 of 10 would appear when it's not required.
jeremystretch
requested changes
Apr 8, 2022
netbox/dcim/views.py
Outdated
| position__isnull=True, | ||
| parent_bay__isnull=True | ||
| ).prefetch_related('device_type__manufacturer') | ||
| ).prefetch_related('device_type__manufacturer').order_by('-pk')[:10] |
Member
There was a problem hiding this comment.
To avoid duplicating the queryset, I suggest declaring it once and then referencing that to get both the limited set ([:10]) and the total count. You can leave the queryset as-is here:
nonracked_devices = Device.objects.filter(
site=instance,
position__isnull=True,
parent_bay__isnull=True
).prefetch_related('device_type__manufacturer')And under the template context, do:
'nonracked_devices': nonracked_devices.order_by('-pk')[:10],
'total_nonracked_devices_count': nonracked_devices.count(),
Same idea with LocationView below. This helps ensure that any future changes to the queryset aren't missed in the second definition.
Author
There was a problem hiding this comment.
Neat. I didn't realise you could do that. Updated FR pushed.
Updating to use a single queryset for both template variables
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8920
Limits the amount of non-racked devices on Site and Location view to 10 and provides a link to the device list this is pre-filtered to the relevant site or location.