Skip to content

Conversation

@apellini
Copy link
Contributor

@apellini apellini commented Mar 25, 2022

Adding ClusterCL Choice to FHRP Group

Fixes: #8830

Adding ClusterCL Choice to FHRP Group
@jeremystretch
Copy link
Member

#8830 proposes adding ClusterXL as an FHRP group protocol, not an IP address role. It needs to be added to FHRPGroupProtocolChoices.

Additionally, if we're going to start including proprietary protocols, IMO they should be arranged under a subgroup. Something like this:

    CHOICES = (
        ('Standard', (
            (PROTOCOL_VRRP2, 'VRRPv2'),
            (PROTOCOL_VRRP3, 'VRRPv3'),
            (PROTOCOL_HSRP, 'HSRP'),
            (PROTOCOL_GLBP, 'GLBP'),
            (PROTOCOL_CARP, 'CARP'),
        ),
        ('Proprietary', (
            (PROTOCOL_CLUSTERXL, 'ClusterXL'),
        ),
        (PROTOCOL_OTHER, 'Other'),
    )

@apellini
Copy link
Contributor Author

So consider that also HSRP and GLBP are Cisco Proprietary.

@jeremystretch
Copy link
Member

True, for GLBP at least; HSRP straddles the fence. I'm happy to put them both under proprietary too.

Adding in choices group standard, checkpoint and cisco and ungroupped other.
@apellini
Copy link
Contributor Author

I have done, please check if it is feasible

@jeremystretch jeremystretch merged commit cde8ff2 into netbox-community:develop Mar 28, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add ClusterXL protocol to the options of the FHRP Group

2 participants