-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Allow filtering on Core models for Contacts #8742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jeremystretch
merged 12 commits into
netbox-community:develop
from
minitriga:issue_8645
Mar 18, 2022
Merged
Allow filtering on Core models for Contacts #8742
jeremystretch
merged 12 commits into
netbox-community:develop
from
minitriga:issue_8645
Mar 18, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and API for contact assignments
Contributor
Author
|
@jeremystretch I have removed all changes to the API. |
jeremystretch
requested changes
Mar 18, 2022
Member
jeremystretch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good. Noted a few minor issues for cleanup. Also, it looks like we still need to define contacts columns on ProviderTable and CircuitTable to be consistent.
Thanks for your work on this!
Co-authored-by: Jeremy Stretch <[email protected]>
Co-authored-by: Jeremy Stretch <[email protected]>
Member
|
Excellent work, thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #8645
Implements filtering for all core models that have contacts.