Skip to content

Conversation

@minitriga
Copy link
Contributor

@minitriga minitriga commented Feb 24, 2022

Fixes: #8645

Implements filtering for all core models that have contacts.

  • Filter by contacts
  • Filter by contact roles
  • Allow contacts to be shown in the table columns

@minitriga minitriga changed the title WIP: Allow filtering on core models in the UI and API for con… WIP: Allow filtering on Core models for Contacts Mar 9, 2022
@minitriga
Copy link
Contributor Author

@jeremystretch I have removed all changes to the API.

@minitriga minitriga changed the title WIP: Allow filtering on Core models for Contacts Allow filtering on Core models for Contacts Mar 9, 2022
Copy link
Member

@jeremystretch jeremystretch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. Noted a few minor issues for cleanup. Also, it looks like we still need to define contacts columns on ProviderTable and CircuitTable to be consistent.

Thanks for your work on this!

@jeremystretch
Copy link
Member

Excellent work, thank you!

@jeremystretch jeremystretch merged commit 1541060 into netbox-community:develop Mar 18, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Searchable Contact Assignments per Content-Type in API/UI

2 participants