Add REMOTE_AUTH_AUTOCREATE_GROUPS #8603
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsks
force-pushed
the
feature/remote-group-autocreate
branch
from
7ae4d1d to
cc5d48c
Compare
Member
|
Thank you for your interest in contributing to NetBox, however it appears there is no accepted issue that correlates to this pull request. Before pull requests are opened, we require an accepted issue as per our contributing guide. Please first open an issue and wait for it to be accepted before further work is done on this pull request. |
Contributor
|
The linked issue is #7671 (although not yet accepted) |
Contributor
Author
|
Sorry, it was linked in the commit message but not the PR description. |
larsks
force-pushed
the
feature/remote-group-autocreate
branch
from
cc5d48c to
c4e556e
Compare
When REMOTE_AUTH_AUTOCREATE_GROUPS is True, Netbox will create groups referenced in the REMOTE_AUTH_GROUP_HEADER that don't exist in the database. Closes netbox-community#7671
larsks
force-pushed
the
feature/remote-group-autocreate
branch
from
c4e556e to
ee1ec29
Compare
Contributor
Author
|
I've rebased this on the current |
larsks
added a commit
to larsks/moc-apps
that referenced
this pull request
Mar 9, 2022
Our upstream patch (netbox-community/netbox#8603) to enable automatic group synchronization with Keycloak hasn't drawn much interest, and I'd like us to be able to use the upstream Netbox image. This commit sets up a `Job` that will perform the necessary database initialization to enable admin logins. The only time this matters is when initially deploying Netbox (but remains useful to us as we experiment with Netbox deployment changes on the staging cluster).
larsks
added a commit
to larsks/moc-apps
that referenced
this pull request
Mar 9, 2022
Our upstream patch (netbox-community/netbox#8603) to enable automatic group synchronization with Keycloak hasn't drawn much interest, and I'd like us to be able to use the upstream Netbox image. This commit sets up a `Job` that will perform the necessary database initialization to enable admin logins. The only time this matters is when initially deploying Netbox (but remains useful to us as we experiment with Netbox deployment changes on the staging cluster).
larsks
added a commit
to larsks/moc-apps
that referenced
this pull request
Mar 9, 2022
Our upstream patch (netbox-community/netbox#8603) to enable automatic group synchronization with Keycloak hasn't drawn much interest, and I'd like us to be able to use the upstream Netbox image. This commit sets up a `Job` that will perform the necessary database initialization to enable admin logins. The only time this matters is when initially deploying Netbox (but remains useful to us as we experiment with Netbox deployment changes on the staging cluster).
larsks
added a commit
to larsks/moc-apps
that referenced
this pull request
Mar 9, 2022
Our upstream patch (netbox-community/netbox#8603) to enable automatic group synchronization with Keycloak hasn't drawn much interest, and I'd like us to be able to use the upstream Netbox image. This commit sets up a `Job` that will initialize the database with the group we use to control access to Netbox. The only time this matters is when initially deploying Netbox (but remains useful to us as we experiment with Netbox deployment changes on the staging cluster).
larsks
added a commit
to larsks/moc-apps
that referenced
this pull request
Mar 9, 2022
Our upstream patch (netbox-community/netbox#8603) to enable automatic group synchronization with Keycloak hasn't drawn much interest, and I'd like us to be able to use the upstream Netbox image. This commit sets up a `Job` that will initialize the database with the group we use to control access to Netbox. The only time this matters is when initially deploying Netbox (but remains useful to us as we experiment with Netbox deployment changes on the staging cluster).
larsks
added a commit
to larsks/moc-apps
that referenced
this pull request
Mar 9, 2022
Our upstream patch (netbox-community/netbox#8603) to enable automatic group synchronization with Keycloak hasn't drawn much interest, and I'd like us to be able to use the upstream Netbox image. This commit sets up a `Job` that will initialize the database with the group we use to control access to Netbox. The only time this matters is when initially deploying Netbox (but remains useful to us as we experiment with Netbox deployment changes on the staging cluster).
larsks
added a commit
to larsks/moc-apps
that referenced
this pull request
Mar 9, 2022
Our upstream patch (netbox-community/netbox#8603) to enable automatic group synchronization with Keycloak hasn't drawn much interest, and I'd like us to be able to use the upstream Netbox image. This commit sets up a `Job` that will initialize the database with the group we use to control access to Netbox. The only time this matters is when initially deploying Netbox (but remains useful to us as we experiment with Netbox deployment changes on the staging cluster).
kkthxbye-code
suggested changes
Apr 1, 2022
| PLUGINS_CONFIG = getattr(configuration, 'PLUGINS_CONFIG', {}) | ||
| RELEASE_CHECK_URL = getattr(configuration, 'RELEASE_CHECK_URL', None) | ||
| REMOTE_AUTH_AUTO_CREATE_USER = getattr(configuration, 'REMOTE_AUTH_AUTO_CREATE_USER', False) | ||
| REMOTE_AUTH_AUTO_CREATE_GROUP = getattr(configuration, 'REMOTE_AUTH_AUTO_CREATE_GROUP', False) |
Contributor
There was a problem hiding this comment.
Suggested change
| REMOTE_AUTH_AUTO_CREATE_GROUP = getattr(configuration, 'REMOTE_AUTH_AUTO_CREATE_GROUP', False) | |
| REMOTE_AUTH_AUTO_CREATE_GROUPS = getattr(configuration, 'REMOTE_AUTH_AUTO_CREATE_GROUPS', False) |
I think you made a copy paste error. When changing it to the above suggestion the PR works as intended.
Contributor
There was a problem hiding this comment.
You should also add the new setting to the docs.
Contributor
|
@larsks - are you still interested in finishing this? When my review has been addressed, it should be good to go. |
Contributor
Author
|
@kkthxbye-code yes, still interested; just ended up with my head in other things for a bit. I'll try submitting an update over the next couple of days. |
Contributor
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further action is taken. |
github-actions
bot
added
the
pending closure
Contributor
|
This PR has been automatically closed due to lack of activity. |
Contributor
|
@larsks Regards |
kkthxbye-code
removed
the
pending closure
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #7671
When REMOTE_AUTH_AUTOCREATE_GROUPS is True, Netbox will create groups
referenced in the REMOTE_AUTH_GROUP_HEADER that don't exist in the
database.