Closes #7668: Add 'View Elevations' button to location detail page #7693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremystretch
requested changes
Nov 1, 2021
Member
jeremystretch
left a comment
jeremystretch
left a comment
There was a problem hiding this comment.
The "controls" block at the top right corner of the page is for actions directly related to the object being viewed: It wouldn't make sense to put a link for rack elevations there. Instead, the link should go next to the count of assigned racks, under the location details block.
Contributor
Author
|
Relocated to the rack row in the location details table.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #7668
Adds 'View Elevations' button to the controls on the Location detail view page.