Closes: #6732 - Add new ASN model #7662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
DanSheps
changed the title
* Re-instates ASN field on Site model * Re-instates ASN field on Site view * Re-instates ASN field on edit form and API, except for where forms instances are new (add site) or instance does not have any existing AS data * Does not re-instate asn field on SiteBulkEditForm * Does not re-instate ASN field on SiteTable * Does not re-instate filter for filterset, but does allow filtering by query (q=34342) * Does not include tests for ASN field on Site model due to planned deprecation
…into 6732-asn-model
jeremystretch
requested changes
Oct 29, 2021
Member
jeremystretch
left a comment
jeremystretch
left a comment
There was a problem hiding this comment.
Great work, @DanSheps! I have some questions about the model and implementation, but a lot of my notes below are just cleanup items.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #6732
Adds a new model for ASN management with associated API, views, forms, filters and views
TODO:
Convert ASNField for GraphQL to string to support dot notation