Fix Primary IP Sorting Issues for Devices and VMs #5820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This does not respect the |
Contributor
Author
That's fine, I can look into it, but can you confirm if your fix for the other issue (https://github.com/netbox-community/netbox/blob/develop/netbox/dcim/tables/devices.py#L132) is also incorrect and does not respect this configuration value? |
Member
|
@stuntguy3000 yes, that needs to be fixed as well. |
stuntguy3000
changed the title
stuntguy3000
changed the title
stuntguy3000
changed the title
stuntguy3000
changed the title
Contributor
Author
|
Okay ignore all that, both issues merged, tested and fixed @jeremystretch. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5819, #5872
Enables ordering by IPv6, followed by IPv4.
Ensures the displayed IP address is IPv6 or IPv4 based on the configuration.