Fixes: #5315 - Make "null_option" on DynamicModelChoiceField also null the value on the model. #5704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l the value on the model.
jeremystretch
requested changes
Feb 11, 2021
Member
jeremystretch
left a comment
jeremystretch
left a comment
There was a problem hiding this comment.
Other than my one note I think this is fine. It feels a bit hacky, but it's certainly preferable to overhauling the choice widgets at the moment.
jeremystretch
approved these changes
Feb 12, 2021
glennmatthews
added a commit
to nautobot/nautobot
that referenced
this pull request
Jun 16, 2021
… various form fields
glennmatthews
added a commit
to nautobot/nautobot
that referenced
this pull request
Jun 16, 2021
… various form fields (#583)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5315
Alter the DynamicModelChoiceField to remove any value that is a string of 'null' if the 'null_option' and then call the parent clean() method.