Proposal to add QSFP+ (64GFC) FibreChannel Interface option re FR #5630 #5670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netbox/dcim/choices.py
Outdated
| TYPE_8GFC_SFP_PLUS = '8gfc-sfpp' | ||
| TYPE_16GFC_SFP_PLUS = '16gfc-sfpp' | ||
| TYPE_32GFC_SFP28 = '32gfc-sfp28' | ||
| TYPE_64GFC_QSFP_PLUS = '64gfc-sfpp' |
Member
There was a problem hiding this comment.
The slug for this value should indicate QSFP+, not SFP+.
Contributor
Author
There was a problem hiding this comment.
Ok I will adjust that. I was following the example of the existing 128GFC QSFP28. Should that one be updated as well?
Currently it is:
TYPE_128GFC_QSFP28 = '128gfc-sfp28'
Member
There was a problem hiding this comment.
Do not alter any other values, as that would break existing installations.
Contributor
Author
There was a problem hiding this comment.
I have updated the slug to be 64gfc-qsfpp now as mentioned.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5630
This proposal will add the QSFP+ (64GFC) interface type for FibreChannel into the netbox/dcim/choices.py script