Skip to content

Fixes #5285: Include plugin API endpoints in root view without needing app_name set #5286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2020
Merged

Fixes #5285: Include plugin API endpoints in root view without needing app_name set #5286

merged 1 commit into from
Oct 30, 2020

Conversation

@jeremystretch
Copy link
Member

@jeremystretch jeremystretch commented Oct 29, 2020

Fixes: #5285

Include plugin REST API endpoints in the root view without requiring the plugin to define app_name in its api/urls.py.

lampwins
lampwins approved these changes Oct 30, 2020
View reviewed changes
Copy link
Contributor

@lampwins lampwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeremystretch jeremystretch merged commit ca932ec into develop Oct 30, 2020
@jeremystretch jeremystretch deleted the 5285-plugins-api-app_name branch October 30, 2020 13:10
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@lampwins lampwins lampwins approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Plugins must define app_name in api/urls.py to be included in API root view

3 participants

@jeremystretch @lampwins