4559 config context rendering #5266
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4559
This implements a new queryset manager for the device and virtual machine models which includes an
annotate_config_context_data()method. This method uses a dynamically generated subquery with theJSONBAggfunction to annotate the list of config context json objects directly on the device and virtual machine querysets.There are a couple of things to note:
JSONBAggfunction for a while but in 3.2 it includes support for aggregation ordering. My implementation includes a custom subclass which implements the same until we move to 3.2. Ordering is a critical component of being able to do this as a subquery.get_for_object()method is still present and actively used. This is still needed to query for the actualConfigContextinstances for a given object, and in certain cases where the annotation is not available.