Fixes #20554: Add ContentTypeFilter to several filtersets #20591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce `ContentTypeFilter` across several filtersets, including `object_type`, `related_object_type`, `assigned_object_type`, and `parent_object_type`. This improvement enhances filtering specificity and aligns with existing usability standards. Closes netbox-community#20554
jeremystretch
requested review from
a team and
bctiemann
and removed request for
a team
pheus
changed the title
bctiemann
approved these changes
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #20554
Summary
Switch
ipam.Servicefiltering to useContentTypeFilterforparent_object_typeand apply the same approach anywhere we expose a generic relation via filters (e.g.,object_type,related_object_type,assigned_object_type). This lets GET filters accept the documented<app>.<model>form (e.g.,virtualization.virtualmachine) and aligns GET with POST and existing usability across the app.What changed
ContentTypeFilterforparent_object_typein the Services filterset.ContentTypeFilterfor similar parameters across filtersets where applicable.<app>.<model>for the affected params.Why
Fixes the “Value must be an integer” error when filtering Services by
parent_object_typeand brings behavior in line with how generic relations are documented and used elsewhere. No database or schema changes.