Fixes #20497: Add range_contains lookup and fix VLANGroup VID range filtering
#20514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Naming note: I used |
jnovinger
requested review from
a team and
jeremystretch
and removed request for
a team
Member
jeremystretch
left a comment
jeremystretch
left a comment
There was a problem hiding this comment.
Awesome work @pheus! Just had a couple minor suggestions.
pheus
force-pushed
the
20497-add-arrayfield-rangefield-lookup
branch
from
dea6408 to
d68f0ab
Compare
pheus
changed the title
any_range_contains lookup and fix VLANGroup VID range filteringrange_contains lookup and fix VLANGroup VID range filtering
pheus
force-pushed
the
20497-add-arrayfield-rangefield-lookup
branch
from
d68f0ab to
5b40ff9
Compare
Introduce a generic lookup for ArrayField(RangeField) that matches rows where a scalar value is contained by any range in the array (e.g. VLANGroup.vid_ranges). Replace the raw-SQL helper in the VLANGroup FilterSet (`contains_vid`) with the ORM lookup for better maintainability. Add tests for the lookup and the FilterSet behavior. Closes netbox-community#20497
pheus
force-pushed
the
20497-add-arrayfield-rangefield-lookup
branch
from
5b40ff9 to
5b6c6e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #20497
Summary
Introduce a generic ORM lookup
range_containsforArrayField(RangeField)to correctly match rows where a scalar value is contained by any range in the array (e.g.,VLANGroup.vid_ranges). This replaces the raw‑SQL helper used by the VLAN group filter and aligns REST and GraphQL semantics with PostgreSQL range operators.Changes
range_containslookup (guarded toArrayField(RangeField)).VLANGroupFilterSet (contains_vid) to use the lookup (remove raw SQL).IntegerRangeArrayLookupinput and wireVLANGroup.vid_rangesto it.vid_ranges: { contains: <Int> }, which maps internally to__range_contains.Tests
?contains_vid=<int>(hit/miss and exclusive upper bound).