Skip to content

Conversation

@DanSheps
Copy link
Member

@DanSheps DanSheps commented Oct 5, 2025

Fixes: #20140 - Registered denormalized fields in CircuitTermination

  • Register denormalized fields on CircuitTermination
    • _location
    • _site

@DanSheps DanSheps requested a review from a team October 5, 2025 03:46
@DanSheps DanSheps self-assigned this Oct 5, 2025
@DanSheps DanSheps requested review from jnovinger and removed request for a team October 5, 2025 03:46
@jeremystretch
Copy link
Member

@DanSheps please rebase this off of main to fix the CI failures.

@jnovinger
Copy link
Member

Doh, my bad. I should not have accepted before seeing the CI failures.

@jnovinger jnovinger self-requested a review October 6, 2025 13:51
@jeremystretch
Copy link
Member

Eh, only the push tests are failing (due to the ruff issue). I think it's fine to merge this as-is given it's a known issue.

@jnovinger jnovinger merged commit f5ed095 into main Oct 6, 2025
10 checks passed
@jnovinger jnovinger deleted the 21040-fixes-denormalized-field branch October 6, 2025 14:12
@jnovinger jnovinger changed the title Fixes: #21040 - Registered denormalized fields in CircuitTermination Fixes: #20140 - Registered denormalized fields in CircuitTermination Oct 6, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Changing a site's region does not change the circuit or circuit-termination region

4 participants