Fixes #20243: Prevent scheduled system jobs from re-running multiple times #20450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremystretch
requested review from
a team and
bctiemann
and removed request for
a team
jnovinger
previously approved these changes
Sep 30, 2025
Member
jnovinger
left a comment
jnovinger
left a comment
There was a problem hiding this comment.
I think this solves the problem as stated and is more than reasonable. I did have a couple of questions, though.
Also, I think we should probably follow this up with a housekeeping issue to add a test that enforces the "subsequent runs of periodic jobs are always in the future" expectation.
jnovinger
approved these changes
Sep 30, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #20243
When determining the new scheduled time for a job with an interval, ensure that it is at least one minute into the future.