Skip to content

Fixes #20425: Fix Markdown preview functionality within "quick add" modal #20444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2025
+8 −18
Merged

Fixes #20425: Fix Markdown preview functionality within "quick add" modal #20444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion netbox/netbox/views/generic/object_views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,8 @@ def get(self, request, *args, **kwargs):
model = self.queryset.model

initial_data = normalize_querydict(request.GET)
form = self.form(instance=obj, initial=initial_data)
form_prefix = 'quickadd' if request.GET.get('_quickadd') else None
form = self.form(instance=obj, initial=initial_data, prefix=form_prefix)
restrict_form_fields(form, request.user)

context = {
Expand Down
6 changes: 3 additions & 3 deletions netbox/project-static/dist/netbox.js
View file
Open in desktop

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions netbox/project-static/dist/netbox.js.map
View file
Open in desktop

Large diffs are not rendered by default.

11 changes: 0 additions & 11 deletions netbox/project-static/src/buttons/markdownPreview.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import { isTruthy } from 'src/util';

/**
* interface for htmx configRequest event
*/
Expand All @@ -17,15 +15,6 @@ function initMarkdownPreview(markdownWidget: HTMLDivElement) {
const textarea = markdownWidget.querySelector('textarea') as HTMLTextAreaElement;
const preview = markdownWidget.querySelector('div.preview') as HTMLDivElement;

/**
* Make sure the textarea has style attribute height
* So that it can be copied over to preview div.
*/
if (!isTruthy(textarea.style.height)) {
const { height } = textarea.getBoundingClientRect();
textarea.style.height = `${height}px`;
}

/**
* Add the value of the textarea to the body of the htmx request
* and copy the height of text are to the preview div
Expand Down