Skip to content

Conversation

@jeremystretch
Copy link
Member

Fixes: #20375

  • Add the get_url_params() method on ObjectAction to return a QueryDict of URL query parameters
  • Provide this QueryDict as url_params in the button template context
  • Update all button templates to reference url_params

@jeremystretch jeremystretch requested review from a team and jnovinger and removed request for a team September 18, 2025 14:41
Copy link
Member

@jnovinger jnovinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and acts pretty solid, except for any list view that uses the BulkSync action class, as noted below.

Also, I noticed that bulk rename has the inverse bug, where when you select the "select all xx s" checkbox, it only seems to act on the ones from the current page--so if pagination is at 25 and there are 37 items that match the filter, only 25 items are acted on for renaming. This appears to be the same behavior across all models.

It looks like this bulk rename issue predated this fix though, so not really a problem here. I couldn't find a bug report for that, so will file one shortly.

@jnovinger jnovinger merged commit 56db60f into main Sep 18, 2025
10 checks passed
@jnovinger jnovinger deleted the 20375-bulk-edit-filters branch September 18, 2025 19:17
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bulk edit with filter applies to all Virtual Machines

3 participants