Fixes #20298: Add placeholder for failed image thumbnail generation #20359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Redis cache lacks disk persistence sorl-thumbnail fails to generate
thumbnails, leaving only bare filename text visible. This adds an
`{% empty %}` fallback block to the thumbnail template that displays a
placeholder with a broken image icon and user instructions when thumbnail
generation fails.
The placeholder maintains the expected 200x200px dimensions and provides:
- Broken image icon (mdi-image-broken-variant)
- Error message explaining the issue
- Clickable link to view the original image
- High contrast text (text-dark) for readability on light background
jnovinger
requested review from
a team and
arthanson
and removed request for
a team
arthanson
approved these changes
Sep 15, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #20298
When Redis cache lacks disk persistence
sorl-thumbnailfails to generate thumbnails, leaving only bare filename text visible. This adds an{% empty %}fallback block to the thumbnail template that displays a placeholder with a broken image icon and user instructions when thumbnail generation fails.The placeholder maintains the expected 200x200px dimensions and provides:
mdi-image-broken-variant)text-dark) for readability on light backgroundThis can be tested by changing the permission on the thumbnail cache directory before adding a thumbnail, via
chmod 444 netbox/media/cache. Just remember to change the permission back after testing.