Fixes #20197: Correct validation for virtual chassis parent interface #20337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue where parent interface validation could improperly check virtual chassis across devices. Ensures accurate validation by referencing the correct parent device and virtual chassis relationships. Fixes netbox-community#20197
jnovinger
requested review from
a team,
jeremystretch and
jnovinger
and removed request for
a team and
jeremystretch
jnovinger
approved these changes
Sep 12, 2025
pheus
deleted the
20197-fix-parent-interface-assignment-validation-for-virtual-chassis
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #20197
Summary
Fixes an
AttributeErrorduring parent interface validation by checking the VC on devices (useself.device.virtual_chassisandself.parent.device.virtual_chassis). This allows a parent on another member of the same VC and rejects mismatches.Thanks @elipsion for the STR and for pointing out the incorrect reference.