Fixes #20234: Correct add_button return_url for prerequisite models #20268
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pass `return_url` by name; it was parsed as `action` in the generic prerequisite include. Fixes netbox-community#20234
jeremystretch
requested review from
a team and
jnovinger
and removed request for
a team
jnovinger
approved these changes
Sep 5, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #20234
Summary
The generic prerequisite include was passing
request.pathas the second positional argument to theadd_buttontemplate tag. Because the tag expects(model, action, return_url), this causedrequest.pathto be interpreted asaction, breaking the "+ Add" link in banners such as "Before you can add a power feed you must first create a power panel."Change
Pass the
return_urlby name so it’s bound correctly by the tag:User impact
Clicking "+ Add" on any prerequisite banner now opens the correct add form and returns the user to the originating page upon completion.