Fixes #20217: Fix '0 VLANs available' in the VLANs table in VLAN Groups #20261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnovinger
requested review from
a team and
jeremystretch
and removed request for
a team
jeremystretch
requested changes
Sep 5, 2025
netbox/ipam/utils.py
Outdated
|
|
||
| # Annotate any remaining available VLANs | ||
| if prev_vid < max_vid: | ||
| if prev_vid < max_vid and (available := max_vid - prev_vid - 1) > 0: |
Member
There was a problem hiding this comment.
While this works, it's a bit confusing IMO. Would it not be sufficient to just account for the off-by-one error (and leave the value of available as is)?
Suggested change
| if prev_vid < max_vid and (available := max_vid - prev_vid - 1) > 0: | |
| if prev_vid < max_vid - 1: |
Contributor
Author
There was a problem hiding this comment.
Fair point! I must have had some tunnel vision going on and didn't see the simpler, cleaner fix.
I'll revise it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #20217
Fixes an issue where the VLANs table under a VLAN Group will display a clickable
0 VLANs availablebutton when the final VLAN in the range is in use.