Closes #18811: Match full-form IPv6 addresses in global search #19873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremystretch
requested review from
a team and
jnovinger
and removed request for
a team
jnovinger
reviewed
Jul 14, 2025
Member
jnovinger
left a comment
jnovinger
left a comment
There was a problem hiding this comment.
I don't think this is in scope, but when I do search for the IPv6 address in expanded form, it does not highlight the matched object, like it does when I search for and find it using the compressed format.
Addresses used for testing:
- Expanded: 2001:0db8:0000:0000:0000:8a2e:0370:7334/64
- Abbreviated: 2001:db8::8a2e:370:7334/64
Other than that (and one tiny grammar quibble in a comment), this all looks great.
jnovinger
previously approved these changes
Jul 14, 2025
Member
jnovinger
left a comment
jnovinger
left a comment
There was a problem hiding this comment.
Derp, meant to approve this.
Member
Author
Yeah, unfortunately I don't think this is feasible. The highlighting works on simple text matching; we would need to somehow expose the IPv6 addressing logic to support it. IMO it's fine to leave this as-is. |
jnovinger
approved these changes
Jul 14, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #18811
ipv6_fullproperty on the Aggregate, Prefix, and IPAddress models (for general use)