Skip to content

Closes #19550: Enhancement: Refactor rack elevations template for lazy loading /dcim/rack-elevations/ #19823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 8, 2025
Merged

Closes #19550: Enhancement: Refactor rack elevations template for lazy loading /dcim/rack-elevations/ #19823

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ffacced
Refactor rack elevation template to use htmx for dynamic loading and …
tbot-ziply May 20, 2025
e73127b
rework to prevent dup loading
tbotnz May 21, 2025
8ef5fbf
Update netbox/templates/dcim/inc/rack_elevation.html
tbotnz Jun 9, 2025
140a186
Update netbox/templates/dcim/inc/rack_elevation.html
tbotnz Jun 9, 2025
7874d3f
Move inline styles to styles/custom/racks.css
jnovinger Jul 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion netbox/project-static/dist/netbox.css
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 4 additions & 0 deletions netbox/project-static/styles/custom/racks.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
.rack-loading-container {
min-height: 200px;
margin-left: 30px;
}
1 change: 1 addition & 0 deletions netbox/project-static/styles/netbox.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,3 +27,4 @@
@import 'custom/markdown';
@import 'custom/misc';
@import 'custom/notifications';
@import 'custom/racks';
13 changes: 12 additions & 1 deletion netbox/templates/dcim/inc/rack_elevation.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,17 @@
{% load i18n %}
<div style="margin-left: -30px">
<object data="{% url 'dcim-api:rack-elevation' pk=object.pk %}?face={{face}}&render=svg{% if extra_params %}&{{ extra_params }}{% endif %}" class="rack_elevation" aria-label="{% trans "Rack elevation" %}"></object>
<div
hx-get="{% url 'dcim-api:rack-elevation' pk=object.pk %}?face={{ face }}&render=svg{% if extra_params %}&{{ extra_params }}{% endif %}"
hx-trigger="intersect"
hx-swap="outerHTML"
aria-label="{% trans "Rack elevation" %}"
>
<div class="d-flex justify-content-center align-items-center rack-loading-container">
<div class="spinner-border" role="status">
<span class="visually-hidden">{% trans "Loading..." %}</span>
</div>
</div>
</div>
</div>
<div class="text-center mt-3">
<a class="btn btn-outline-primary" href="{% url 'dcim-api:rack-elevation' pk=object.pk %}?face={{face}}&render=svg{% if extra_params %}&{{ extra_params }}{% endif %}" hx-boost="false">
Expand Down