Fixes #19800: ModuleType import supports associating ModuleTypeProfile #19803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also includes an additional regression assertion.
jnovinger
requested review from
a team and
jeremystretch
and removed request for
a team
jnovinger
commented
Jul 2, 2025
netbox/dcim/tests/test_views.py
Outdated
| InterfaceTemplate, FrontPortTemplate, RearPortTemplate, ModuleBayTemplate, | ||
| ] | ||
| for model in additional_permissions: | ||
| obj_perm.object_types.add(ObjectType.objects.get_for_model(model)) |
Member
Author
There was a problem hiding this comment.
Open to suggestions on this approach.
Member
There was a problem hiding this comment.
There's an add_permissions() method on the test case to facilitate this; will that work?
jeremystretch
requested changes
Jul 3, 2025
netbox/dcim/tests/test_views.py
Outdated
| InterfaceTemplate, FrontPortTemplate, RearPortTemplate, ModuleBayTemplate, | ||
| ] | ||
| for model in additional_permissions: | ||
| obj_perm.object_types.add(ObjectType.objects.get_for_model(model)) |
Member
There was a problem hiding this comment.
There's an add_permissions() method on the test case to facilitate this; will that work?
netbox/dcim/forms/bulk_import.py
Outdated
| fields = [ | ||
| 'manufacturer', 'model', 'part_number', 'description', 'airflow', 'weight', 'weight_unit', 'comments', | ||
| 'tags', | ||
| 'tags', 'profile', |
Member
There was a problem hiding this comment.
Could you move profile before comments in the list? It affects the ordering of the fields in the import form.
I ultimately left the extra asserts in for test_bulk_import_objects_with_permissionsince since the parent test is currently only testing against number of objects successfully imported. Will file a follow up FR to improve that test.
jeremystretch
approved these changes
Jul 14, 2025
jeremystretch
deleted the
19800-module-type-import-does-not-assign-profile
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #19800
profileto the list of fields the import form should recognizeBulkImportObjectsViewTestCase