Fixes #19687 - Treat cellular interface type as not connectable #19691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add cable termination test for cellular interface
jnovinger
previously approved these changes
Jun 11, 2025
| with self.assertRaises(ValidationError): | ||
| cable.clean() | ||
|
|
||
| def test_cable_cannot_terminate_to_a_cellular_interface(self): |
Member
There was a problem hiding this comment.
Thanks for adding the regression test!
jnovinger
reviewed
Jun 11, 2025
| with self.assertRaises(ValidationError): | ||
| cable.clean() | ||
|
|
||
| def test_cable_cannot_terminate_to_a_cellular_interface(self): |
Member
There was a problem hiding this comment.
Derp, meant to also ask ... can you add a 'regression' tag here, like so?
@tag('regression')
def test_cable_cannot_terminate_to_a_cellular_interface(self):
...
Member
There was a problem hiding this comment.
You can import it like
from django.test import tag
Contributor
Author
There was a problem hiding this comment.
My bad I misunderstood the comment on the issue. I'll add and update the PR.
Member
There was a problem hiding this comment.
It couldn't have helped that it took me three comments to say what I meant to say. 🤦
Thanks!
jnovinger
approved these changes
Jun 12, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #19687
Add cellular interface types to WIRELESS_IFACE_TYPES const
Add cable termination test for cellular interface