#19680 fix deletion dependency order for GenericRelations #19681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnovinger
reviewed
Jun 11, 2025
Member
jnovinger
left a comment
jnovinger
left a comment
There was a problem hiding this comment.
Just had the one question. Otherwise, this looks pretty sane and well contained.
| # | ||
|
|
||
| class ChangeLoggingMixin(models.Model): | ||
| class ChangeLoggingMixin(DeleteMixin, models.Model): |
Member
There was a problem hiding this comment.
@arthanson , just to be clear, we only want to employee this mechanism for ChangedLoggingMixin and no other, correct?
Collaborator
Author
There was a problem hiding this comment.
Yes, it only matters in that case. This changes the order that the delete signal handlers are sent out, but the only reason we care about that is what order the ObjectChange records are written out, so this only effects models derived from ChangeLoggingMixin.
arthanson
changed the title
jnovinger
approved these changes
Jun 13, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #19680