Fixes #19677 - Call none() when VRF is None in IPAddress and Prefix filter_present_in_vrffilters
#19678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures the `queryset.none()` method is called properly with parentheses. This fixes a potential issue where the method would not execute as intended, improving the stability and correctness of the filter logic.
pheus
changed the title
filter_present_in_vrffiltersfilter_present_in_vrffilters
Contributor
Author
|
I'm sorry for opening this PR before the issue was triaged — I understand that may be a bit premature. This is more of a small drive-by fix that I wanted to wrap up while I had a moment, as I may be quite busy in the coming days. I hope that's okay, and I really appreciate your understanding. |
jnovinger
approved these changes
Jun 9, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #19677 - IPAM FilterSet: filter_present_in_vrf method returns queryset.none instead of calling it when VRF is None
Ensures the
queryset.none()method is called properly with parentheses. This fixes a potential issue where the method would not execute as intended, improving the stability and correctness of the filter logic.