Fixes #19520: restore ability to set Prefix.scope via API #19588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turned out that the `.prefetch_related('scope')` on the
`PrefixViewSet.queryset` attribute was causing `scope` to not be set on
the prefix instance being changed, even though `scope_id` _was_ set. I
only found this when comparing the behavior of API endpoints for other
models that make use of the `CachedScopeMixin` model mixin.
jnovinger
requested review from
a team and
arthanson
and removed request for
a team
arthanson
approved these changes
May 27, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #19520
It turned out that the
.prefetch_related('scope')on thePrefixViewSet.querysetattribute was causingscopeto not be set on the prefix instance being changed--even thoughscope_idwas set--causing the check inCachedScopeMixin.clean()to fail. I only found this when comparing the behavior of API endpoints for other models that make use of theCachedScopeMixinmodel mixin.