Skip to content

Fixes #17107: Circuit to Provider Network cabling visual bug #19403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2025
Merged

Fixes #17107: Circuit to Provider Network cabling visual bug #19403

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions netbox/dcim/svg/cables.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,11 +329,9 @@ def draw_attachment(self):

# Draw attachment (line)
start = (OFFSET + self.center, OFFSET + self.cursor)
height = PADDING * 2 + LINE_HEIGHT + PADDING * 2
end = (start[0], start[1] + height)
end = (start[0], start[1] + CABLE_HEIGHT)
line = Line(start=start, end=end, class_='attachment')
group.add(line)
self.cursor += PADDING * 4

return group

Expand All @@ -358,10 +356,10 @@ def render(self):
# Else: No need to draw parent objects (parent objects are drawn in last "round" as the far-end!)

near_terminations = self.draw_terminations(near_ends, parent_object_nodes)
self.cursor += CABLE_HEIGHT

# Connector (a Cable or WirelessLink)
if links and far_ends:
self.cursor += CABLE_HEIGHT

obj_list = {end.parent_object for end in far_ends}
parent_object_nodes, far_terminations = self.draw_far_objects(obj_list, far_ends)
Expand Down Expand Up @@ -449,6 +447,7 @@ def render(self):
# Attachment
attachment = self.draw_attachment()
self.connectors.append(attachment)
self.cursor += CABLE_HEIGHT

# Object
parent_object_nodes = self.draw_parent_objects(far_ends)
Expand Down