Skip to content

Fixes #19346: Ensure all redirect URLs are validated #19347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2025
Merged

Fixes #19346: Ensure all redirect URLs are validated #19347

merged 1 commit into from
Apr 30, 2025

Conversation

@jeremystretch
Copy link
Member

@jeremystretch jeremystretch commented Apr 28, 2025

Fixes: #19346

  • Introduce the safe_for_redirect() utility function
  • Ensure it's used to wrap all redirect URLs that could potentially contain user-originated data

github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 28, 2025
View reviewed changes
@jeremystretch jeremystretch marked this pull request as ready for review April 28, 2025 18:44
@jeremystretch jeremystretch requested review from a team and bctiemann and removed request for a team April 28, 2025 18:44
@bctiemann bctiemann merged commit c0e6168 into main Apr 30, 2025
10 checks passed
@jeremystretch jeremystretch deleted the 19346-redirect-checks branch April 30, 2025 18:06
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bctiemann bctiemann bctiemann approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Redirect URLs are not sanitized in some cases

3 participants

@jeremystretch @bctiemann