Fixes: #19275 - Make type choice for interfaces non-required #19276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanSheps
requested review from
a team and
jeremystretch
and removed request for
a team
Member
jeremystretch
left a comment
jeremystretch
left a comment
There was a problem hiding this comment.
I coincidentally just addressed this in #19283. Is there any reason not to just set field.widget.is_required = False?
Member
Author
Nope, I was just being extra cautious to make sure that there wasn't any issue with perhaps a null widget or anything. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #19275 - Make type choice for interfaces non-required
form_from_modelto also mark the widget itself as non-required