Fixes #18879 - Add prefix filtering by assigned VLAN Group #19182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces filters for VLAN groups using both ID and slug fields.
Introduces a `vlan_group_id` filter to IPAM forms for filtering based on VLAN groups.
jeremystretch
requested changes
Apr 14, 2025
Member
jeremystretch
left a comment
jeremystretch
left a comment
There was a problem hiding this comment.
Other than one minor note this looks good to go. Thanks!
Introduces tests for VLAN group filtering in FilterSets. This ensures correct validation and behavior when filtering by VLAN group.
pheus
force-pushed
the
18879-add-prefix-filtering-by-vlan-group
branch
from
bbb52b4 to
1fb2d1c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18879 - Add prefix filtering by assigned VLAN Group
Overview
This PR enhances NetBox by enabling filtering of prefixes by the assigned VLAN Group. Users can now filter using both quick search (by VLAN Group slug) and FilterForm (by ID).
Changes Introduced
vlan_group_idfilter for direct filtering by VLAN Group.Thank you for reviewing this PR!