Fixes: #16144 GetReturnURLMixin Support for Plugin Views #18996
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renatoalmeidaoliveira
requested review from
a team and
jeremystretch
and removed request for
a team
jeremystretch
requested changes
Mar 26, 2025
Member
jeremystretch
left a comment
jeremystretch
left a comment
There was a problem hiding this comment.
Can we simplify the logic here to avoid duplicating the view name?
netbox/utilities/views.py
Outdated
| # Attempt to dynamically resolve the list view for the object | ||
| if hasattr(self, 'queryset'): | ||
| model_opts = self.queryset.model._meta | ||
| is_plugin = isinstance(self.queryset.model._meta.app_config, PluginConfig) |
Member
There was a problem hiding this comment.
Suggested change
| is_plugin = isinstance(self.queryset.model._meta.app_config, PluginConfig) | |
| prefix = 'plugins:' if isinstance(self.queryset.model._meta.app_config, PluginConfig) else '' |
netbox/utilities/views.py
Outdated
Comment on lines
155
to
158
| if is_plugin: | ||
| return reverse(f'plugins:{model_opts.app_label}:{model_opts.model_name}_list') | ||
| else: | ||
| return reverse(f'{model_opts.app_label}:{model_opts.model_name}_list') |
Member
There was a problem hiding this comment.
Suggested change
| if is_plugin: | |
| return reverse(f'plugins:{model_opts.app_label}:{model_opts.model_name}_list') | |
| else: | |
| return reverse(f'{model_opts.app_label}:{model_opts.model_name}_list') | |
| return reverse(f'{prefix}{model_opts.app_label}:{model_opts.model_name}_list') |
Contributor
Author
|
@jeremystretch since |
jeremystretch
approved these changes
Mar 27, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #16144 GetReturnURLMixin Support for Plugin Views
querysetuse case ofGetReturnURLMixin