Skip to content

Conversation

@jeremystretch
Copy link
Member

Fixes: #18955

  • Enable the clear_button Tom-Select plugin only for fields without required set

@jeremystretch
Copy link
Member Author

Need to determine why we're not setting the required attribute on required <select> fields.

@jeremystretch jeremystretch marked this pull request as ready for review April 9, 2025 18:05
@jeremystretch jeremystretch requested review from a team and bctiemann and removed request for a team April 9, 2025 18:05
@jeremystretch
Copy link
Member Author

jeremystretch commented Apr 10, 2025

Need to determine why we're not setting the required attribute on required <select> fields.

AFAICT it's just not included in the template. We do use a custom template for the <select> widget, but it's not in Django's native template either. Feels like it should be, so I've added it.

@jeremystretch jeremystretch merged commit 6ed41f6 into main Apr 11, 2025
6 checks passed
@jeremystretch jeremystretch deleted the 18955-conditional-clear-button branch April 11, 2025 12:20
@jeremystretch jeremystretch modified the milestone: v4.2.8 Apr 11, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dropdown widgets for required fields should not include a "clear" button

3 participants