Fixes: #18939 Allow ASN search by site-group #18948
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renatoalmeidaoliveira
requested review from
a team and
bctiemann
and removed request for
a team
jeremystretch
requested review from
jeremystretch
and removed request for
bctiemann
jeremystretch
requested changes
Mar 19, 2025
Member
jeremystretch
left a comment
jeremystretch
left a comment
There was a problem hiding this comment.
Looks good, but please include tests for the new filters under ipam.tests.test_filtersets.ASNTestCase.
Contributor
Author
|
Included the test cases following |
jeremystretch
approved these changes
Mar 20, 2025
Member
jeremystretch
left a comment
jeremystretch
left a comment
There was a problem hiding this comment.
Thanks @renatoalmeidaoliveira!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #18939 Allow ASN search by site-group
There're tests implemented in
PrefixTestCasefor site groups, should I implement similar tests cases for ASN site group too?