Fixes #18869: Ensure to_meters() always returns a clean decimal value
#18883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremystretch
requested review from
a team and
jnovinger
and removed request for
a team
jnovinger
requested changes
Mar 12, 2025
Member
jnovinger
left a comment
jnovinger
left a comment
There was a problem hiding this comment.
Let me know if "length won't always be an int" is a bad assumption. This looks good otherwise.
jnovinger
approved these changes
Mar 12, 2025
Member
jnovinger
left a comment
jnovinger
left a comment
There was a problem hiding this comment.
💥 Just waiting on CI to finish
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #18869
to_meters()always returns a decimal value rounded to four decimal placesto_meters()&to_grams()