Fixes #18838: Correctly reject invalid falsy local context data #18860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnovinger
requested review from
a team and
jnovinger
and removed request for
a team
jnovinger
changed the title
jnovinger
requested changes
Mar 11, 2025
Member
jnovinger
left a comment
jnovinger
left a comment
There was a problem hiding this comment.
The change does the trick. However, let's move the tests to be as close to the code change as possible.
fabi125
commented
Mar 11, 2025
Contributor
Author
fabi125
left a comment
fabi125
left a comment
There was a problem hiding this comment.
Sure! Tests moved.
jnovinger
approved these changes
Mar 11, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #18838
Reject falsy values like the empty string, 0 or False as local context data.
I verified that
None/nullstill works as expected and that an empty string in UI gets correctly converted toNonebeforeclean()is called.