Fixes #18782: Misconfigured ObjectListWidgets now degrade gracefully
#18854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If this is done incorrently, then the string formatting operation turns `htmx_url` into a string and the test in the template fails.
jnovinger
requested review from
a team and
bctiemann
and removed request for
a team
jnovinger
changed the title
jnovinger
changed the title
ObjectListWidget now degrade gracefully
jnovinger
changed the title
ObjectListWidget now degrade gracefullyObjectListWidgets now degrade gracefully
Contributor
|
@jnovinger This works in scope, however I noticed another weird adjacent behavior which we might want to try to fix at the same time if possible, if it's in the same code area (if not, I'll open a separate bug). 
If you click the X to clear the "Widget type" value (or backspace the existing value), the page immediately bombs to this error: 
This behavior is in |
bctiemann
approved these changes
Mar 18, 2025
jnovinger
deleted the
18782-dashboard-broken-on-notification-list-widget
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #18782
This PR does two things to address this bug:
htmx_urlhas query params added so that we don't try to add them toNone. This has the effect of properly triggering the branch in the template that indicates this widget can not be displayed.ObjectListWidget.ConfigForm.modelvia aclean_modelmethod that checks to make sure that a model is supported byObjectListWidgetat the time of creation. This results in the following error for the user:I'm open to adjust that error message as needed.
I also played around with disabling unsupported object choices, but ended up not including those in the PR. Will add a screenshot if anyone is interested in seeing them.