Fixes: #18582 Bulk import prefixes with associated VLAN not working when multiple VLANs with the same vid exist. #18844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renatoalmeidaoliveira
requested review from
a team and
jeremystretch
and removed request for
a team
jeremystretch
requested changes
Mar 10, 2025
netbox/ipam/forms/bulk_import.py
Outdated
| to_field_name='name', | ||
| help_text=_("VLAN's group (if any)") | ||
| ) | ||
| site = CSVModelChoiceField( |
Member
There was a problem hiding this comment.
We should rename this to vlan_site to make it clear that the field is considered for only the VLAN to which the prefix is being assigned, and not the prefix itself.
Suggested change
| site = CSVModelChoiceField( | |
| vlan_site = CSVModelChoiceField( |
netbox/ipam/forms/bulk_import.py
Outdated
| fields = ( | ||
| 'prefix', 'vrf', 'tenant', 'vlan_group', 'vlan', 'status', 'role', 'scope_type', 'scope_id', 'is_pool', | ||
| 'mark_utilized', 'description', 'comments', 'tags', | ||
| 'prefix', 'vrf', 'tenant', 'vlan_group', 'site', 'vlan', 'status', 'role', 'scope_type', 'scope_id', |
Member
There was a problem hiding this comment.
Suggested change
| 'prefix', 'vrf', 'tenant', 'vlan_group', 'site', 'vlan', 'status', 'role', 'scope_type', 'scope_id', | |
| 'prefix', 'vrf', 'tenant', 'vlan_group', 'vlan_site', 'vlan', 'status', 'role', 'scope_type', 'scope_id', |
jeremystretch
approved these changes
Mar 11, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #18582 Bulk import prefixes with associated VLAN not working when multiple VLANs with the same vid exist.
PrefixImportFormalready implemented a test case for VLANSiteandVLANGroupcodeCSVModelChoiceFieldfor vlan_group was implementedThe fix consisted in implementing a
CSVModelChoiceFieldforSiteAditional observations:
It should be possible to setup the
VLANqueryset to the same as the Prefix scope if existent, but IMO that could lead to unwanted results, like:VLANthat doesn't belong to anySite, thatVLANgonna be missing in the queryset.