Fixes: #18579 Add contact filters to services #18818
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renatoalmeidaoliveira
requested review from
a team and
jnovinger
and removed request for
a team
jnovinger
requested changes
Mar 5, 2025
Member
jnovinger
left a comment
jnovinger
left a comment
There was a problem hiding this comment.
Contact related filters are not working for ProviderAccount--I'm seeing false positives. Looks like maybe you missed updating the filterset.
jnovinger
requested changes
Mar 5, 2025
Member
There was a problem hiding this comment.
Hey @renatoalmeidaoliveira , my apologies, I noticed something on my second look that I completely missed the first time re: parent class ordering. Let me know if you have any questions.
The changes for my the review look great, thanks. Also, added a couple of suggestions for import ordering, for consistency's sake.
Setup NetBoxModelFilterSetForm as the last inherited class Co-authored-by: Jason Novinger <[email protected]>
jnovinger
approved these changes
Mar 6, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #18579 Add contact filters to services
ContactModelFilterSetto everyModelFilterSetwhere it was missingContactModelFilterFormto everyModelFilterFormwhere it was missingFieldSetforContactsAs @bctiemann commented in the issue, there were several other model classes with ContactsMixin that didn’t have the appropriate fields and filters.
The following models were fixed in this PR:
ServicesProviderAccountAggregatePrefixIPRangeIPAddressL2VPNTunnelGroupTunnel