Fixes 17357: Use virtual chassis name as fallback for device #18710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some use cases, a device does not have an individual name when it is a member of a virtual chassis. By adding the virtual chassis to the search index and making its name searchable, forms can use the virtual chassis name instead in these situations.
If a name is not defined for a device, it is automatically generated from other device data (i.e. virtual chassis member) if possible. This name is available as 'label' attribute to not interfere with existing functionality or break APIs.
jeremystretch
requested review from
a team and
arthanson
and removed request for
a team
arthanson
requested changes
Feb 25, 2025
Generating the device label doesn't require much computing power. Thus, caching does more harm than good, as it may return stale labels after name changes. Now a fresh label is always generated.
arthanson
approved these changes
Feb 25, 2025
bctiemann
pushed a commit
that referenced
this pull request
Mar 6, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #17357
If a name is not defined for a device, it is automatically generated from other device data (i.e. virtual chassis member) if possible. This name is available as
labelattribute to not interfere with existing functionality or break APIs. This label will be used in several places like tables, while the API still returns the real name.