Skip to content

Fixes #18594: asn_count sort in Sites list #18634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 20, 2025
Merged

Fixes #18594: asn_count sort in Sites list #18634

merged 2 commits into from
Feb 20, 2025

Conversation

@jnovinger
Copy link
Member

@jnovinger jnovinger commented Feb 12, 2025

Fixes: #18594 - Site list can now be sorted by the asn_count column

Changes:

  • adds asn_count annotation
  • removes now unnecessary accessor argument for asn_count column

@jnovinger jnovinger requested a review from bctiemann February 12, 2025 20:16
bctiemann
bctiemann requested changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

@bctiemann bctiemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ProviderListView needs this same fix.

@jeremystretch
Copy link
Member

jeremystretch commented Feb 18, 2025

@jnovinger could you please apply the same fix for the asn_count column on circuits.tables.ProviderTable?

@jnovinger
Copy link
Member Author

jnovinger commented Feb 18, 2025

@jnovinger could you please apply the same fix for the asn_count column on circuits.tables.ProviderTable?

Fix committed, looking to see what testing opportunities we might have.

@jnovinger
Copy link
Member Author

jnovinger commented Feb 19, 2025

Fix committed, looking to see what testing opportunities we might have.

Looks like we don't currently have any tests for various table subclasses, outside of one small example. While I think it's worthwhile to add tests, seems like it might be outside the scope for this ticket, especially since the change in behavior is not using an in-house customization. @jeremystretch , thoughts?

jeremystretch
jeremystretch approved these changes Feb 20, 2025
View reviewed changes
Copy link
Member

@jeremystretch jeremystretch left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extending the test scope would be outside of this particular PR. Thanks @jnovinger!

@jeremystretch jeremystretch merged commit 2a44aff into netbox-community:main Feb 20, 2025
3 checks passed
@jnovinger jnovinger deleted the 18594-fix-asn_count-ordering branch February 25, 2025 14:58
bctiemann pushed a commit that referenced this pull request Mar 6, 2025
@jnovinger @bctiemann
Fixes #18594: asn_count sort in Sites list (#18634)
ad2898e 
* Fixes #18594: asn_count sort in Sites list

* Fixes similar issue in `circuits.views.ProviderListView`

Thanks @bctiemann for point this out!
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bctiemann bctiemann bctiemann approved these changes

@jeremystretch jeremystretch jeremystretch approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cannot Sort By asn_count Column For Sites Table And Providers View Table

3 participants

@jnovinger @jeremystretch @bctiemann