Fixes: 18593 - "Create & Add Another" broken for new IP addresses #18602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremystretch
requested changes
Feb 7, 2025
netbox/ipam/views.py
Outdated
| return obj | ||
|
|
||
| def get_extra_addanother_params(self, request): | ||
| extra_params = super().get_extra_addanother_params(request) |
Member
There was a problem hiding this comment.
No need to call super(); it can just return an empty dictionary.
jeremystretch
approved these changes
Feb 11, 2025
bctiemann
pushed a commit
that referenced
this pull request
Mar 6, 2025
…8602) * update IPAddressEditView get_extra_addanother_params * Simplify get_extra_addanother_params
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #18593 - "Create & Add Another" broken for new IP addresses
super().get_extra_addanother_params(request)when the GET paramsinterfaceorvminterfaceIts also possible to solve this issue returning
{}if there aren't any match in the if clauses, IMO returningsuper().get_extra_addanother_params(request)could be more flexible in the future.Please let me know if you prefer to use another approach.