Fixes: #18013 - All saved filters showing up for Change Log table, regardless of defined object type

[renatoalmeidaoliveira]

Fixes: #18013 - All saved filters showing up for Change Log table, regardless of defined object type

Since ObjectChangeFilterForm doesn't inherid from NetBoxModelFilterSetForm the filter_id field doesn't get updated

Changes:

• Add __init__ method to ObjectChangeFilterForm, and setup filter_id query_params

[renatoalmeidaoliveira]

That issue also affects:
Config Contexts
Config Templates
Custom Fields
Custom Field Choice Sets
Custom Links
Export Templates
Saved Filters
Image Attachments
Jobs
Notification Groups

[renatoalmeidaoliveira]

The current solution, solves the issue only for ChangeLog as reported in the issue.
For a broaden solution, IMO the best approach is change the SavedFiltersMixin adding a __init__ block that setups the object_type_id query_param in the filter_id widget and remove that block from NetBoxModelFilterSetForm
The solution also requires to add a model attribute for every FilterForm that doesn't have it already, like: JobFilterForm

[bctiemann]

@renatoalmeidaoliveira I think you're right, this functionality should go into SavedFiltersMixin. I also see what you mean about the JobFilterForm and other similar forms -- let's go ahead and add those model attributes and make sure everything still works as expected.

[jeremystretch]

Found a couple more forms that need to have model declared:

• ConfigRevisionFilterForm
• JobFilterForm

I can knock these out real quick.

[jeremystretch]

Thanks @renatoalmeidaoliveira!