Skip to content

Fixes: #18436 - Prevent unassigning mac address when primary on an interface #18445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 24, 2025
Merged

Fixes: #18436 - Prevent unassigning mac address when primary on an interface #18445

merged 3 commits into from
Jan 24, 2025

Conversation

@DanSheps
Copy link
Member

@DanSheps DanSheps commented Jan 21, 2025 •
edited
Loading

Fixes: #18436 - Prevent unassigning mac address when primary on an interface

  • Prevent unassigning mac address when set as primary on an interface
  • Prevent reassigning mac address when set as primary on an interface
  • Update UI to prevent editing when MACAddress is set as primary

@DanSheps DanSheps marked this pull request as draft January 21, 2025 05:10
@DanSheps DanSheps marked this pull request as ready for review January 21, 2025 05:45
@DanSheps DanSheps requested a review from bctiemann January 21, 2025 05:45
@DanSheps DanSheps self-assigned this Jan 21, 2025
@bctiemann bctiemann merged commit e02ae72 into main Jan 24, 2025
6 checks passed
@jeremystretch jeremystretch deleted the 18436-fix-unassign-mac-with-primary branch January 24, 2025 13:08
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bctiemann bctiemann bctiemann approved these changes

Assignees

@DanSheps DanSheps

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unassigning MAC Address from interface does not reset primary mac address

3 participants

@DanSheps @bctiemann