Fixes: #18336 - Perform Rack object validation of u_height and starting_unit on rack_type if present #18395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremystretch
approved these changes
Jan 17, 2025
jeremystretch
deleted the
18336-validate-rack-height-and-starting-unit
branch
bctiemann
added a commit
that referenced
this pull request
Jan 28, 2025
bctiemann
added a commit
that referenced
this pull request
Jan 29, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #18336
Current model validation in
Rack.clean()examines theu_heightandstarting_unitfields but only considers the fields on the Rack itself, not on the RackType if assigned, in which those fields' values override those on the Rack. This can lead to a situation where a Rack with assigned devices above a certain elevation can be assigned to a RackType incompatible with those elevations, because the validation misses the effectiveu_heightandstarting_unitof the requested RackType. Subsequent errors occur in SVG rendering andRackFormvalidation.This situation is prevented with this change, which ensures that these two fields are validated with consideration of both Rack and RackType values, and assigns the resulting
ValidationErrorto the appropriate form field depending on whether a RackType has been selected or not.