Fixes: #18350 - Remove 'site' and 'provider_network' from CircuitTerminationIndex.display_attrs #18351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
IMO this should also display the scoping data that replaces the site and provider_network fields, not just stop the crash. |
jeremystretch
requested changes
Jan 10, 2025
jeremystretch
approved these changes
Jan 17, 2025
jeremystretch
deleted the
18350-remove-scoping-fields-on-CircuitTerminationIndex
branch
bctiemann
added a commit
that referenced
this pull request
Jan 28, 2025
bctiemann
added a commit
that referenced
this pull request
Jan 29, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #18350
As
CircuitTerminationhas been refactored to move the fieldssiteandprovider_networkto the new scoping model, this change uses the new internal (cached) versions of those fields in the displayed attributes in search results, resolving a crash condition.